Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated README file to reflect template changes #860

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

Mashal-m
Copy link
Contributor

Description

The README of the MFEs needs to be updated because the frontend app template has been updated.

Issue related: openedx/wg-frontend#169

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (33cce3f) 85.13%.
Report is 72 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   84.87%   85.13%   +0.26%     
==========================================
  Files         320      325       +5     
  Lines        6399     6728     +329     
  Branches     1552     1633      +81     
==========================================
+ Hits         5431     5728     +297     
- Misses        941      969      +28     
- Partials       27       31       +4     
Files Coverage Δ
src/components/contact-admin-mailto/index.jsx 100.00% <100.00%> (ø)
src/components/course/CourseContextProvider.jsx 100.00% <100.00%> (ø)
src/components/course/CourseMainContent.jsx 100.00% <ø> (ø)
src/components/course/CoursePage.jsx 93.75% <100.00%> (ø)
src/components/course/CourseRecommendationCard.jsx 96.00% <100.00%> (+0.16%) ⬆️
src/components/course/CourseSidebar.jsx 100.00% <100.00%> (ø)
src/components/course/CourseSidebarListItem.jsx 100.00% <ø> (ø)
src/components/course/EnrollModal.jsx 93.54% <100.00%> (ø)
src/components/course/VerifiedCertPitch.jsx 100.00% <ø> (ø)
...c/components/course/course-header/CourseHeader.jsx 100.00% <100.00%> (ø)
... and 112 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review October 31, 2023 08:21
@Mashal-m Mashal-m merged commit 6feaf52 into master Oct 31, 2023
5 checks passed
@Mashal-m Mashal-m deleted the mashal-m/update-README branch October 31, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants